Add Hydra searchpath for rf3 and rfd3 model-specific configs #166
+17
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Ubiquinone-dot <[email protected]>
Co-authored-by: Ubiquinone-dot <[email protected]>
Copilot
AI
changed the title
[WIP] Add search path for rfd3 configurations
Add Hydra searchpath for rf3 and rfd3 model-specific configs
Jan 14, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adds Hydra searchpath configuration entries to enable proper discovery of model-specific config packages for rf3 and rfd3 models. The PR ensures that Hydra can locate the model-specific configs packaged as rf3.configs and rfd3.configs before falling back to a shared pkg://configs location.
Changes:
- Added
pkg://rf3.configssearchpath entries to rf3's inference.yaml, train.yaml, and validate.yaml - Added
pkg://rfd3.configssearchpath entries to rfd3's validate.yaml and dev.yaml (inference.yaml and train.yaml were already updated in a previous commit)
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| models/rfd3/configs/validate.yaml | Added rfd3.configs searchpath for validation configuration |
| models/rfd3/configs/dev.yaml | Added rfd3.configs searchpath for development inference configuration |
| models/rf3/configs/validate.yaml | Added rf3.configs searchpath for validation configuration |
| models/rf3/configs/train.yaml | Added rf3.configs searchpath for training configuration |
| models/rf3/configs/inference.yaml | Added rf3.configs searchpath for inference configuration |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Ubiquinone-dot
added a commit
that referenced
this pull request
Jan 15, 2026
* Add search path for rfd3 configurations * Add search path for rfd3 configurations * Add Hydra searchpath for rf3 and rfd3 model-specific configs (#166) * Initial plan * Add search path for rf3 configurations Co-authored-by: Ubiquinone-dot <[email protected]> * Add rfd3 searchpath to validate.yaml and dev.yaml Co-authored-by: Ubiquinone-dot <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: Ubiquinone-dot <[email protected]> --------- Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extends #144 by adding Hydra searchpath configuration for rf3 model configs, and completes the rfd3 implementation by adding missing searchpath entries to validate.yaml and dev.yaml.
Both rf3 and rfd3 configs are packaged as
rf3.configsandrfd3.configsrespectively (configured in pyproject.toml), but Hydra couldn't locate them without explicit searchpath entries.Changes:
pkg://rf3.configssearchpath to inference.yaml, train.yaml, and validate.yamlpkg://rfd3.configssearchpath to validate.yaml and dev.yaml (inference.yaml and train.yaml were already updated in previous commit)Both models now consistently use their model-specific configs package before falling back to shared
pkg://configs:💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.